Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): enable vuelidate config and extract notification #494

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Mar 11, 2024

Vuelidate Config

Came across the situation I need to use $scope option of vuelidate, so enabling passing in the config.

useV({}, {}, { $scope: 'profile' })

Extract notification composable

Just so that we can:

const { validation: baseV } = useV({}, {}, { $scope: 'base' })
const { validation: profileV } = useV({}, {}, { $scope: 'profile' })
const { notify } = useVNotification()

// Instead of

const { validation: baseV, notify } = useV({}, {}, { $scope: 'base' })
const { validation: profileV } = useV({}, {}, { $scope: 'profile' })

@kiaking kiaking added the enhancement New feature or request label Mar 11, 2024
@kiaking kiaking requested a review from brc-dd March 11, 2024 02:24
@kiaking kiaking self-assigned this Mar 11, 2024
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e17f0bd
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65ee6b60ec246c00075b2437
😎 Deploy Preview https://deploy-preview-494--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e17f0bd
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65ee6b617d350c000845def1
😎 Deploy Preview https://deploy-preview-494--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kiaking kiaking merged commit aaeefbe into main Mar 11, 2024
9 checks passed
@kiaking kiaking deleted the validation branch March 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants