Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action-list): support showing tooltip and implement disabled prop #516

Merged
merged 71 commits into from
May 2, 2024
Merged

feat(action-list): support showing tooltip and implement disabled prop #516

merged 71 commits into from
May 2, 2024

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Apr 10, 2024 •
edited

brc-dd added 30 commits April 5, 2024 11:05
@brc-dd
feat: teleport tooltip to avoid stacking issues
e4cb517
@brc-dd
add teleport target globally
c281cbf
@brc-dd
add teleport target to vitepress
4b7483b
@brc-dd
vitepress ssr teleports
a9c0b94
@brc-dd
skip tests
0c1bcc7
@brc-dd
preserve visibility
c4eabdc
@brc-dd
update comment
d83b719
@brc-dd
hide on scroll
bd56ef7
@brc-dd
use absolute positioning instead of fixed
ced0ef5
@brc-dd
show preview story url in docs if previewing
01eb520
@brc-dd
show preview docs url in story if previewing
ce8e9ef
@brc-dd
handle padding via css and dont hide tooltip while selecting text fro…
bc3deee 
…m tip and adjust naming to align with composable
@brc-dd
restore timeout logic and working tests
eb9b01c
@brc-dd
move stuff to vitest setup file
28513a0
@brc-dd
fix histoire auto complete
ebf9cea
@brc-dd
move shims outside
b7a33a3
@brc-dd
add 200ms delay to avoid showing tooltip while scrolling past some te…
c3d9a0d 
…xt and fix logic
@brc-dd
move more stuff to vitest setup
362f190
@brc-dd
shims for vue are not needed
ce62237
@brc-dd
update path
75dc621
@brc-dd
fix false positives
ba5a6fe
@brc-dd
handled undefined too
f455c16
@brc-dd
try hiding on click outside
ee9416c
@brc-dd
prevent hide from triggering multiple times and make event listeners …
bfb9b94 
…passive
@brc-dd
manually run cleanups to avoid issues with bf-cache
fef4b16
@brc-dd
add event listeners globally
b95d211
@brc-dd
delay set and eager reset globalHide
2758e41
@brc-dd
globalHide is redundant
bfdc54d
@brc-dd
revert
ed05017
@brc-dd
revert
3cdd752
@brc-dd brc-dd changed the base branch from avatar-tooltip to main April 16, 2024 07:00
@brc-dd brc-dd changed the base branch from main to avatar-tooltip April 16, 2024 07:06
@brc-dd brc-dd changed the base branch from avatar-tooltip to main April 16, 2024 07:07
@brc-dd brc-dd changed the base branch from main to avatar-tooltip April 16, 2024 07:11
@brc-dd brc-dd changed the base branch from avatar-tooltip to main April 16, 2024 07:11
@brc-dd brc-dd changed the base branch from main to avatar-tooltip April 16, 2024 07:16
@brc-dd brc-dd changed the base branch from avatar-tooltip to main April 16, 2024 07:16
brc-dd and others added 3 commits April 16, 2024 12:46
kiaking
kiaking reviewed May 2, 2024
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I looked into this one before #515. Can we merge this once and close #515?

I've adjusted display of tooltip wince it wasn't being block and wasn't filling up entire width when tooltip is present.

Could you test it again, and if everything works great, please revert story and merge it 👍

@brc-dd
Copy link
Member Author

brc-dd commented May 2, 2024 •
edited

Ah, it breaks SAvatarStack 👀 It should be inline-block by default too instead of undefined 👀 But no, something else appears to be breaking it again. I remember having fixed it earlier.

@brc-dd brc-dd requested a review from kiaking May 2, 2024 04:22
@brc-dd
Copy link
Member Author

brc-dd commented May 2, 2024

Fixed it. Check once and please revert the action list story. We can keep table one if you want 👀

@kiaking
Copy link
Member

kiaking commented May 2, 2024

@brc-dd
Looking good to me! I've adjusted the font size/weight on action list item, and reverted action list story. Let's keep table story as is 👍

@brc-dd brc-dd merged commit 7f2abd1 into main May 2, 2024
9 checks passed
@brc-dd brc-dd deleted the actionlist-tooltip branch May 2, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees

@brc-dd brc-dd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ActionList] Add "disabled" feature
2 participants
@brc-dd @kiaking