Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with the interleave() function #52

Closed
henriquesposito opened this issue Sep 23, 2021 · 3 comments · Fixed by #72
Closed

Decide what to do with the interleave() function #52

henriquesposito opened this issue Sep 23, 2021 · 3 comments · Fixed by #72
Assignees

Comments

@henriquesposito
Copy link
Contributor

Since resequence() was moved to messydates, interleave is now is a function in qCreate and a helper function in messydates (since it is called by resequence() and because messydates is on CRAN it cannot/should not have GitHub dependencies).

A couple of options:

  1. Once a new version of messydates is live we could, for example, export interleave() there and either call the function in qCreate from messydates or a make it wrapper function in qCreate for it.

  2. We can better incorporate the interleave code into resequence() within messydates and keep interleave() as an exported function from qCreate.

@henriquesposito henriquesposito self-assigned this Sep 23, 2021
@jhollway
Copy link
Contributor

Hmm, I wonder whether it might be more efficient to have it be in qData (when it is on CRAN) and then used by both?

@jhollway
Copy link
Contributor

Would it perhaps make sense to have interleave be an exported messydates function?

@henriquesposito
Copy link
Contributor Author

This is a good idea! I will get into that right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants