Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to open tabs as discarded #6

Open
globau opened this issue Sep 5, 2022 · 1 comment
Open

Add option to open tabs as discarded #6

globau opened this issue Sep 5, 2022 · 1 comment

Comments

@globau
Copy link
Owner

globau commented Sep 5, 2022

To do this we'll need to call browser.windows.create with a single url, wait for the window to be created, then use browser.tabs.create to add the other tabs with a discarded property.

Need to determine if the issue with the promise returned by browser.windows.create never returning has been fixed.

@globau
Copy link
Owner Author

globau commented Nov 7, 2022

Need to determine if the issue with the promise returned by browser.windows.create never returning has been fixed.

What's happening is I'm creating the windows from within stash.js, which is run within the popup window's context. When the window closes, the script is terminated so the promise has no where to send the result to.

Instead the popup should be messaging the background script, which in turn handles window creation, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant