Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Emitter debug output and writing logs #272

Merged
merged 4 commits into from
May 12, 2022
Merged

Suppress Emitter debug output and writing logs #272

merged 4 commits into from
May 12, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 12, 2022

Description of the Change

Extending SyncEmitter with overloaded file methods will suppress writing log files if the vendor/snowplow/snowplow-tracker/debug is writable

Adding ob_start / ob_end_clean wrapper for $tracker->trackUnstructEvent() will suppress stdout if the directory is not writable.

Closes #271

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul added this to the 1.1.1 milestone May 12, 2022
@jeffpaul
Copy link
Contributor

@cadic when you're set on the PR, could you please push the branch to the 10up test site for us to validate there?

@cadic cadic requested a review from jeffpaul May 12, 2022 14:30
@jeffpaul jeffpaul merged commit ab0574d into develop May 12, 2022
@jeffpaul jeffpaul deleted the fix/271 branch May 12, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyncEmitter produce output in debug mode
2 participants