Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIT-2708: Fix: get cached responses from post type #305

Merged
merged 3 commits into from Jun 22, 2022
Merged

SIT-2708: Fix: get cached responses from post type #305

merged 3 commits into from Jun 22, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR addresses some issues that were preventing us to get the cached responses from Sophi. Basically

  • Use have_posts() instead of found_posts, as this is not compatible with no_found_rows
  • Make sure WP_Query looks for posts with draft status
  • Fixes a problem with getting post meta in the correct format

Tested in the VIP environment

Closes #

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

felipeelia
felipeelia previously approved these changes Jun 21, 2022
View reviewed changes
@jeffpaul jeffpaul added this to the 1.2.0 milestone Jun 22, 2022
@jeffpaul
Copy link
Contributor

@Sidsector9 @cadic looking for one of you to help review this as well, thanks!

Sidsector9
Sidsector9 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul changed the title Fix: get cached responses from post type SIT-2708: Fix: get cached responses from post type Jun 22, 2022
@jeffpaul
Copy link
Contributor

Relates to https://voltron.atlassian.net/servicedesk/customer/portal/41/SIT-2708

@jeffpaul jeffpaul linked an issue Jun 22, 2022 that may be closed by this pull request
SIT-2708: Should curation result posts be saved in a site option? #153
Closed
@jeffpaul jeffpaul merged commit 3fa21b6 into develop Jun 22, 2022
@jeffpaul jeffpaul deleted the caching-fixes branch June 22, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia approved these changes

@Sidsector9 Sidsector9 Sidsector9 approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

@cadic cadic Awaiting requested review from cadic

Assignees

@oscarssanchez oscarssanchez

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

SIT-2708: Should curation result posts be saved in a site option?
4 participants
@oscarssanchez @jeffpaul @felipeelia @Sidsector9