Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenID Connect Authentication #367

Closed
rafaveira3 opened this issue Sep 30, 2019 · 5 comments
Closed

Add OpenID Connect Authentication #367

rafaveira3 opened this issue Sep 30, 2019 · 5 comments
Labels
feature-request New feature request

Comments

@rafaveira3
Copy link
Contributor

rafaveira3 commented Sep 30, 2019 •
edited

It would be great if we add OpenID Connect authentication into huskyCI API!

By doing so, we could allow users to login using Github and Gitlab, giving us the possibility to check which repositories a developer has acess to, profile image, and many others.

Our FE will consume this when we add a login authentication page, for instance! 🙃
@moogacs
Copy link

moogacs commented Oct 1, 2019

i would like to work on that , so ?

@rafaveira3 rafaveira3 changed the title Add Github Authentication Add OpenID Connect Authentication Oct 1, 2019
@rafaveira3 rafaveira3 mentioned this issue Oct 1, 2019
Closed
@rafaveira3
Copy link
Contributor Author

rafaveira3 commented Oct 1, 2019 •
edited

Hey, @moogacs! Thanks a lot for reaching out! 🙃

I have just spoken with @mdjunior and he is currently refactoring some code (at #365) that would eventually impact this issue. He will give us a further explanation about his progression so we can set a good strategy on how to work on this one. 🚀

@rafaveira3 rafaveira3 removed the feature-request New feature request label Oct 2, 2019
@mdjunior
Copy link
Contributor

mdjunior commented Oct 2, 2019 •
edited by rafaveira3

Hey, @moogacs!

There are some challenges to make huskyci-API authenticate using OpenID Connect. At this moment I'm working refactoring the huskyci-client to make it like a familiar CLI. After this, I will implement the authentication flow at CLI.

We are using a labstack echo framework to husky-API, and you can help us to implement a middleware compatible with JWT and Husky-Tokens. You can read more about this at echo middleware docs.

@rafaveira3 rafaveira3 mentioned this issue Oct 3, 2019
Closed
@sagar-cs03
Copy link

Hi @rafaveira3, I would like to work on this :)

@rafaveira3 rafaveira3 added feature-request New feature request and removed hacktoberfest labels Nov 22, 2019
@rafaveira3
Copy link
Contributor Author

Closing this one due to long inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moogacs @mdjunior @rafaveira3 @sagar-cs03