How to close demo after "end( )" ?

[guifelix]

It should have a "close( )" method to close the terminal after ending.

[rafaelcamargo]

A previous PR seems to be related to this. Investigate the best approach to handle this issue.

[guifelix]

I don't know if I understood it right, but this PR is about returning a promise, right? But nothing about closing the terminal after "end()". If I'm mistaken please disregard this comment

[rafaelcamargo]

🤔
I was wondering that returning a promise you could do something like:

gdemo.openApp('terminal').command('node demo.js').end().then(() => {
  // here you can make anything, including an animation to simulate terminal close.
});

However, you might be meaning:

gdemo.openApp('terminal').command('node demo.js').closeApp('terminal').end();

Is this (closeApp) what you mean?

[guifelix]

Now that you've mentioned... I can see purpose on both approaches!

here is what I'm trying to do:

new Promise((resolve, reject) => {
            new GDemo('#shell').openApp('terminal', {minHeight: '350px', promptString: '$'})
                .command('google-chrome index.html', {onCompleteDelay: 1500})
                .respond('Opening in existing browser session.')
                // .command('clear', {onCompleteDelay: 1500})
                .command('')
                .end();
            setTimeout(() => resolve("done!"), 6500);
        })
        .then(() => {
            // Trying to simulate terminal "clear"
            // $('#shell > div > div > div > div.application-content-container > div:nth-child(1)').remove();
            // $('#shell > div > div > div > div.application-content-container > div:nth-child(2)').remove();
            // $('#shell > div > div > div > div.application-content-container > div:nth-child(3)').remove();
            // Some logic here
            var currentLine = $('.cursor-active');

            var options = {
                strings: ["Some string to be typed inside GDemo with this other lib (https://mattboldt.com/demos/typed-js/)"],
                typeSpeed: 40,
                startDelay: 200
            }

            $(currentLine).addClass('cursor');
            var typed = new Typed(".cursor-active", options);
            $(currentLine).removeClass('cursor-active');

        })
        .then(() => {
            GDemo('#shell').closeApp()
        });

[rafaelcamargo]

I think I got it now. To do this, three improvements would be actually need:

1 - .end() should return a promise
2 - A new method to close applications should be created .closeApp(appName)
3 - A new method to clear terminal applications should be created .clear()

Doing so, your code will be something like that:

const demo = new GDemo('#shell');

demo.openApp('terminal', {minHeight: '350px', promptString: '$'})
  .command('google-chrome index.html', {onCompleteDelay: 1500})
  .respond('Opening in existing browser session.')
  .command('clear', {onCompleteDelay: 1500})
  .clear()
  .command('')
  .end()
  .then(() => {
    return new Promise((resolve, reject) => {
      // Do the stuff with third party lib
    })
  })
  .then(() => {
    demo.closeApp('terminal').end();
  });

Is it right?

[guifelix]

Yeah, pretty much it!

[rafaelcamargo]

Split in the following issues:

• Make .end() return a promise
• Create a method to close some application
• Create a method to clear terminal content