Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESCRIPTION to match citation #133

Open
HedvigS opened this issue Oct 28, 2023 · 8 comments
Open

Update DESCRIPTION to match citation #133

HedvigS opened this issue Oct 28, 2023 · 8 comments

Comments

@HedvigS
Copy link

HedvigS commented Oct 28, 2023

Could we update the DESCRIPTION document to match the citation? I can do the PR if you'd like @SietzeN

@SietzeN
Copy link
Collaborator

SietzeN commented Oct 31, 2023

Thanks a lot @HedvigS, I just discussed this with @ruidongsmile as well. Yes please go ahead and do the PR. By the way, @ruidongsmile has just implemented grambank to glottospace as well.

@HedvigS
Copy link
Author

HedvigS commented Nov 6, 2023

Okay, thanks!

What does it mean to implement grambank in glottospace practically?

@HedvigS
Copy link
Author

HedvigS commented Nov 6, 2023

I see https://github.com/glottospace/glottospace/blob/main/R/glottoget_grambank.R now, okay that's fair. I'd prefer using rcldf and rgrambank, but they're not released yet so that's fair.

@HedvigS
Copy link
Author

HedvigS commented Nov 6, 2023

We've written this page which may be of interest to @ruidongsmile : https://github.com/grambank/grambank/wiki/Fetching-and-analysing-Grambank-data-with-R

@xrotwang
Copy link

xrotwang commented Nov 6, 2023

@HedvigS note that this wiki page still has the now-disfunctional Zenodo URL.

@HedvigS
Copy link
Author

HedvigS commented Nov 6, 2023

@HedvigS note that this wiki page still has the now-disfunctional Zenodo URL.

Stimmt.
When I have time, I'm planning on rewriting the page to primarily direct people to rcldf and rgrambank, and add curl as a second alternative.

@ruidongsmile
Copy link
Collaborator

@HedvigS By "implementing grambank in glottospace", we mean that:

  1. There is an internal version of grambank dataset, which is the Version v1.0.3.
  2. With the function glottoget(), if set glottodata = "grambank" and download = TRUE, the user can download the latest version of grambank. I checked the rgrambank, it seems in rgrambank so far it contains only the url of v1.0.3.
  3. Moreover, in the function glottoget() if set glottodata = "grambankspace", the user can get a spatially enhanced version of grambank, that is an sf object. The document of glottoget contains more details of that.

@HedvigS
Copy link
Author

HedvigS commented Nov 7, 2023

@HedvigS By "implementing grambank in glottospace", we mean that:

  1. There is an internal version of grambank dataset, which is the Version v1.0.3.
  2. With the function glottoget(), if set glottodata = "grambank" and download = TRUE, the user can download the latest version of grambank. I checked the rgrambank, it seems in rgrambank so far it contains only the url of v1.0.3.
  3. Moreover, in the function glottoget() if set glottodata = "grambankspace", the user can get a spatially enhanced version of grambank, that is an sf object. The document of glottoget contains more details of that.

Got it. With rgrambank and rcldf, we recommend people to fetch the data from Zenodo, Git etc and then use the packages functions on the fetched data rather than store it internally. I'll have a closer look at the glottoget implementation for grambank

That's neat with the sf object :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants