-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DESCRIPTION to match citation #133
Comments
Thanks a lot @HedvigS, I just discussed this with @ruidongsmile as well. Yes please go ahead and do the PR. By the way, @ruidongsmile has just implemented grambank to glottospace as well. |
Okay, thanks! What does it mean to implement grambank in glottospace practically? |
I see https://github.com/glottospace/glottospace/blob/main/R/glottoget_grambank.R now, okay that's fair. I'd prefer using rcldf and rgrambank, but they're not released yet so that's fair. |
We've written this page which may be of interest to @ruidongsmile : https://github.com/grambank/grambank/wiki/Fetching-and-analysing-Grambank-data-with-R |
@HedvigS note that this wiki page still has the now-disfunctional Zenodo URL. |
Stimmt. |
@HedvigS By "implementing grambank in glottospace", we mean that:
|
Got it. With rgrambank and rcldf, we recommend people to fetch the data from Zenodo, Git etc and then use the packages functions on the fetched data rather than store it internally. I'll have a closer look at the glottoget implementation for grambank That's neat with the sf object :). |
Could we update the DESCRIPTION document to match the citation? I can do the PR if you'd like @SietzeN
The text was updated successfully, but these errors were encountered: