Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give suggestions for images to use for NFT #183

Merged
merged 3 commits into from Jul 11, 2022

Conversation

benborgers
Copy link
Collaborator

I chose some photos from Unsplash that looked cool. Demo: https://nftoken-git-l-5357-give-suggestions-for-images-to-use-for.luma-dev.com/create-an-nft

What do you think of the photos?

I did Unsplash because the photos can be freely used, whereas I know for example DALL-E explicitly says you can’t use their art for NFTs.

@benborgers benborgers requested a review from vpontis July 11, 2022 18:30
@vercel
Copy link

vercel bot commented Jul 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nftoken ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 7:34PM (UTC)

@benborgers benborgers changed the title Give suggestions for images to use for the first NFT Give suggestions for images to use for NFT Jul 11, 2022
@vpontis
Copy link
Collaborator

vpontis commented Jul 11, 2022

@benborgers we should choose or crop to get square images. Let's also upload them to our CDN which you can do with https://lu.ma/style-guide/drop-zone

@benborgers
Copy link
Collaborator Author

Ok! I’m cropping them on Unsplash’s CDN right now so they’re square — should I reupload them to our CDN and crop them using our CDN?

@vpontis
Copy link
Collaborator

vpontis commented Jul 11, 2022

I think we should upload square images to our CDN

@benborgers
Copy link
Collaborator Author

@vpontis Done!

@benborgers benborgers merged commit 3026bbc into master Jul 11, 2022
@benborgers benborgers deleted the l-5357-give-suggestions-for-images-to-use-for branch July 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants