Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compression? #88

Closed
lorenzhs opened this issue Dec 13, 2013 · 2 comments · Fixed by #103
Closed

Implement compression? #88

lorenzhs opened this issue Dec 13, 2013 · 2 comments · Fixed by #103

Comments

@lorenzhs
Copy link
Member

Initial fetching of lines from WeeChat can take a very long time. I am not entirely sure what causes this (it just takes a long time until the response is there, no idea where the delay comes from, but it doesn't appear to be glowing-bear). Compression might help.

(Sorry I'm just filing tons of issues, but I'm working on understanding the project and how to communicate with the relay server and hope that I'll find the time to fix them)

@cormier
Copy link
Member

cormier commented Dec 13, 2013

Hi lorenzhs, you don't need to be sorry for filling issues: it's an helpful contribution!

he relay code is implemented in the weechat.js according to this spec:

www.weechat.org/files/doc/devel/weechat_relay_protocol.en.html

@lorenzhs
Copy link
Member Author

Yep, I saw the spec, but it's not really complete (there is no documentation there on the hdata commands etc). But the WeeChat developers are really helpful, pointing out anything not in the spec. The whole relay communication thing is more about #86 though.

On compression: If the option is set, all traffic is zlib compressed: source

This project seems to be how the cool kids to compression/decompression in JS nowadays. Since it seems to be doing a lot of things, maybe it is possible to just take the zlib decompression part. Otherwise, maybe a slimmer library would be the better choice. (It would be great if we were able to use native code for that, given that browsers are dealing with zlib anyway, but JavaScript doesn't seem to expose that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants