Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize pointcuts with methodDeclaringClassName "*" #204

Closed
trask opened this issue Apr 27, 2017 · 0 comments
Closed

Optimize pointcuts with methodDeclaringClassName "*" #204

trask opened this issue Apr 27, 2017 · 0 comments
Milestone

Comments

@trask
Copy link
Member

trask commented Apr 27, 2017

Currently, methodDeclaringClassName of * (especially in conjunction with methodName of * and methodParameterTypes of ..) causes a heavy burden on instrumentation checking and retained memory in AnalyzedWorld.java for tracking potential matches (even though the instrumentation will only be applied to subclasses of className).

This should be optimized by matching methodDeclaringClassName only against subclasses of className when it is a pattern, and against superclasses (in order words against all classes) when it is not a pattern, e.g. see AsyncHttpClientAspect.java.

This will break at least one current use (e.g. ResultSetAspect.java) but this one in particular should be easy to re-write using two pointcuts instead of using the | pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant