Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowroot causes error de-serializing #395

Closed
sldab opened this issue May 23, 2018 · 2 comments
Closed

Glowroot causes error de-serializing #395

sldab opened this issue May 23, 2018 · 2 comments
Labels
Milestone

Comments

@sldab
Copy link
Contributor

sldab commented May 23, 2018

We are using Apache Ignite in our clustered application with Ignite's OptimizedMarshaller.
The OptimizedMarshaller is simply based on ObjectOutputStream and does not enforce serialized objects to implement the Serializable interface.

If we activate or deactivate the Glowroot agent on one of the nodes, it crashes upon start as Ignite bootstrap messages from other nodes cannot be unmarshalled due to incompatible ObjectOutputStreams.

Falling back to the JdkMarshaller that relies on plain java serialization is an option, but only works if the classes of all cached objects are serializable or externalizable.

I am missing an option that would allow me to configure a list of packages and/or classes to be blacklisted for weaving in the UI and config.json. Ideally, custom instrumentations should override this blacklist, so I can pick classes of interest of a blacklisted package.

Do you see any issues with such a functionality?

@trask trask closed this as completed in 2a89cf8 May 24, 2018
@trask trask added the bug label May 24, 2018
@trask trask added this to the v0.10.10 milestone May 24, 2018
@trask
Copy link
Member

trask commented May 24, 2018

Hi @sldab, thanks for reporting this! I think the problem is that Glowroot was not marking fields it adds as transient. I'm hoping this is fixed now in the latest snapshot release glowroot-agent-0.10.10-SNAPSHOT-dist.zip.

@sldab
Copy link
Contributor Author

sldab commented May 25, 2018

Hi @trask, thank you for fixing this so quickly. I like this fix very much. Tested it with the snapshot version and it looks fine.

My gut feeling tells me that we still might need some sort of instrumentation blacklist for debugging purposes if we roll out the agent on a bigger scale. But let's see...

@trask trask changed the title Weaving blacklist required Glowroot causes error de-serializing Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants