Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowroot does not work with WildFly 15 on Open JDK 13 #660

Closed
carl-payne opened this issue Nov 4, 2019 · 6 comments
Closed

Glowroot does not work with WildFly 15 on Open JDK 13 #660

carl-payne opened this issue Nov 4, 2019 · 6 comments
Milestone

Comments

@carl-payne
Copy link

Recently upgraded our application from WildFly 15 on Open JDK 11 to WildFly 15 on Open JDK 13 and when running Glowroot version: 0.13.3 locally on server hosting our application encounter errors similar to:

2019-11-04 11:21:23.360 ERROR o.g.a.ManagementFactoryHackClassFileTransformer - Unsupported class file major version 57
java.lang.IllegalArgumentException: Unsupported class file major version 57

Full error in attached log file
glowroot.2019-11-04.log

Please review and advise

Regards
Carl

glowroot.2019-11-04.zip

@atulpendse
Copy link

Facing similar issue with tomcat 8 + jdk 13

2020-01-03T04:53:32.809467-08:00 vm_test tomcat[24171]: 2020-01-03 04:53:32.808 ERROR o.g.a.ManagementFactoryHackClassFileTransformer - Unsupported class file major version 57
java.lang.IllegalArgumentException: Unsupported class file major version 57
    at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:184)
    at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
    at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:152)
    at org.glowroot.agent.ManagementFactoryHackClassFileTransformer.transform(ManagementFactoryHackClassFileTransformer.java:48)
    at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:246)
    at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
    at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:563)
    at org.glowroot.agent.MainEntryPoint.premain(MainEntryPoint.java:151)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Nati

@ilyusha
Copy link

ilyusha commented Jan 28, 2020

We are having the same issue with jetty 9.4 with JDK 13:

2020-01-28 22:41:03.147 ERROR o.g.a.ManagementFactoryHackClassFileTransformer - Unsupported class file major version 57
java.lang.IllegalArgumentException: Unsupported class file major version 57
	at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:184)
	at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
	at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.<init>(ClassReader.java:152)
	at org.glowroot.agent.ManagementFactoryHackClassFileTransformer.transform(ManagementFactoryHackClassFileTransformer.java:48)
	at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:246)
	at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
	at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:563)
	at org.glowroot.agent.MainEntryPoint.premain(MainEntryPoint.java:151)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at org.glowroot.agent.AgentPremain.premain(AgentPremain.java:59)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:513)
	at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:525)

Does glowroot support JDK 13?

@meabhi007
Copy link

meabhi007 commented Jan 31, 2020

I am also facing the issue with Javaagent using JDK13.
Is there a way, we can build the javaagent for JDK13?

Adding the stacktrace for reference:

2020-01-31 13:57:44.241 ERROR o.g.central.CollectorServiceImpl - ussuhvvm0437.egeng.info::appserver - 2020-01-31 13:57:39.392 ERROR org.glowroot.agent.weaving.WeavingClassFileTransformer - error weaving com/egain/platform/modules/profiles/profiles/management/ProfilesInitializer: Unsupported class file major version 57
java.lang.IllegalArgumentException: Unsupported class file major version 57
at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:184)
at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:166)
at org.glowroot.agent.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:152)
at org.glowroot.agent.weaving.Weaver.weaveUnderTimer(Weaver.java:184)
at org.glowroot.agent.weaving.Weaver.weave(Weaver.java:149)
at org.glowroot.agent.weaving.WeavingClassFileTransformer.transformInternal(WeavingClassFileTransformer.java:117)
at org.glowroot.agent.weaving.WeavingClassFileTransformer.transform(WeavingClassFileTransformer.java:94)
at org.glowroot.agent.weaving.WeavingClassFileTransformer.transformJava9(WeavingClassFileTransformer.java:77)
at org.glowroot.agent.weaving.WeavingClassFileTransformer.transform(WeavingClassFileTransformer.java)
at sun.instrument.TransformerManager.transform(TransformerManager.java:188)
at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:563)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:1016)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:515)
at java.net.URLClassLoader$1.run(URLClassLoader.java:423)
at java.net.URLClassLoader$1.run(URLClassLoader.java:417)
at java.security.AccessController.doPrivileged(AccessController.java:691)
at java.net.URLClassLoader.findClass(URLClassLoader.java:416)
at java.lang.ClassLoader.loadClass(ClassLoader.java:588)
at java.lang.ClassLoader.loadClass(ClassLoader.java:521)
at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:543)
at java.lang.ClassLoader.loadClass(ClassLoader.java:521)
at org.eclipse.jetty.util.Loader.loadClass(Loader.java:64)
at org.eclipse.jetty.servlet.BaseHolder.doStart(BaseHolder.java:88)
at org.eclipse.jetty.servlet.ListenerHolder.doStart(ListenerHolder.java:73)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:350)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:822)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)

@trask
Copy link
Member

trask commented Jan 31, 2020

Probably the asm dependency needs to be updated

@meabhi007
Copy link

Thanks for the pointer @trask , Is there any plan to update that dependency and test with JDK13?

@trask trask added this to the v0.13.6 milestone Mar 4, 2020
@trask
Copy link
Member

trask commented Mar 4, 2020

Hi all, this should be fixed now in 0.13.6

@trask trask closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants