Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history cap in memory units #412

Closed
azonenberg opened this issue Apr 8, 2022 · 1 comment
Closed

Add history cap in memory units #412

azonenberg opened this issue Apr 8, 2022 · 1 comment
Assignees
Labels
core Core application logic
Milestone

Comments

@azonenberg
Copy link
Collaborator

In addition to the user controlled history depth, we should also prevent the history from using too much RAM.

The actual history cap should be the minimum of the depth specified in the history window and a preference which specifies the max history depth, in GB.

Additionally, when adding new waveforms to the history, if total free system memory would drop below a safety margin (new preference), then old history should be purged regardless of preferences and the history depth cap.

@azonenberg azonenberg added the core Core application logic label Apr 8, 2022
@azonenberg azonenberg added this to the v0.1 milestone Apr 8, 2022
@azonenberg azonenberg self-assigned this Apr 8, 2022
@azonenberg
Copy link
Collaborator Author

Closing as wontfix since we now have the option of pushing history to files instead, relieving RAM pressure. Needs more internal work but that is the long term plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core application logic
Projects
None yet
Development

No branches or pull requests

1 participant