Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View color ramp setting is not saved / restored in *.scopesession #433

Closed
bvernoux opened this issue Jun 17, 2022 · 3 comments
Closed

View color ramp setting is not saved / restored in *.scopesession #433

bvernoux opened this issue Jun 17, 2022 · 3 comments

Comments

@bvernoux
Copy link
Contributor

bvernoux commented Jun 17, 2022

Issue reproduced with latest version of glscopeclient af2c022 on windows 10 (using https://github.com/glscopeclient/scopehal-apps/suites/6973742607/artifacts/272626580)
View => color ramp setting is not saved / restored in *.scopesession
Can be easily reproduced with any signal displaying for example an Eyepattern with View->Color ramp different from default CRT (example if we choose Rainbow we save the sessions and restore it, it will restore default View->Color ramp => CRT)

@azonenberg azonenberg transferred this issue from ngscopeclient/scopehal Jun 17, 2022
@azonenberg
Copy link
Collaborator

The current color ramp was intended to be a user preference, not a file setting (i.e. it should follow the user and if you load a scopesession on another user's workstation it should use their preferred colors).

It's not currently saved as such. We should have a greater discussion as to whether it makes sense for this to be a per-file or per-user setting.

Also, I'd like to be able to have more than one ramp selected for different uses (e.g. eye patterns and spectrograms might not be best to use the same ramp).

@bvernoux
Copy link
Contributor Author

bvernoux commented Jun 17, 2022

Yes that feature clearly requires refactoring to be stored with *.scopesession per chan requiring it (which a setting to override global settings ?)
Short term could be to have a way to change globally the default "View->Color ramp" to something different from default "CRT" (as it is clearly ugly)

@azonenberg
Copy link
Collaborator

Fixed in ngscopeclient from day one, glscopeclient is deprecated so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants