Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker issue #435

Closed
bvernoux opened this issue Jun 17, 2022 · 6 comments
Closed

Marker issue #435

bvernoux opened this issue Jun 17, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@bvernoux
Copy link
Contributor

When using Marker all work fine visually but when saving/restoring a *.scopesession the markers are broken with invalid values(negatives) and when the scopesession is loaded nothing is displayed (even the waveform).
Issue reproduced with latest version of glscopeclient af2c022 on windows 10 (using https://github.com/glscopeclient/scopehal-apps/suites/6973742607/artifacts/272626580)
File used are based on Rigol MSO5K import (with 2 chan) I can provide them if required

@azonenberg
Copy link
Collaborator

Please attach test files and screenshots.

@azonenberg azonenberg added the bug Something isn't working label Jun 17, 2022
@azonenberg
Copy link
Collaborator

Also, please check if the "nothing displayed on waveform" issue is related to 524c645.

Does reverting to prior to this commit fix it?

@bvernoux
Copy link
Contributor Author

It seems this issue is also affected by the new bug #436 (newly introduced in latest fix ?? as I have never seen that in older glscopeclient used 1 week ago), so I will wait this bug to be fixed before

@azonenberg
Copy link
Collaborator

Please check if f1d109b fixes the rendering issue.

@bvernoux
Copy link
Contributor Author

This issue is related to #436

@azonenberg
Copy link
Collaborator

Closing this and tracking #442 as a separate issue for "markers don't work in sessions without an attached scope".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants