Rigol MSO5K bin import issue after save/load scopesession (scopesession corrupted regression)

[bvernoux]

Rigol MSO5K bin import issue after save/load scopesession

Issue reproduced with latest version of glscopeclient af2c022 on windows 10 (using https://github.com/glscopeclient/scopehal-apps/suites/6973742607/artifacts/272626580)
See full steps with files to reproduce the issue

1. Import the file CH569_SerDes_Speed_IRQ_inline_optim_Chan1_TX_Chan2_RX_5us.bin from archive
   CH569_SerDes_Speed_IRQ_inline_optim_Chan1_TX_Chan2_RX_5us.zip
2. All is fine and perfectly displayed (need zoom out fully to see the full capture)

• Minor issue 2 channels does not have any name it shall be something like Chan1, Chan2
  

3. Click on File => Save Layout and Waveforms As

• Save the file in easy path like D:\Test (so both files Test.scopesession & Test_data directory with sub-dir/files are created with success)
• See the archive Test.zip

4. Choose File => Close
5. Choose File => Open... and choose D:\Test.scopesession
   I cannot zoom out to see the previous screen like on 2)
   

[bvernoux]

This issue does not appear when using glscopeclient version 050bdee from 7 June 2022
When I do all the steps in my first comment this version generate correctly "scopesession + data" (which can be loaded with success which display correctly the data and with Zoom Out working ...) see result Test1_OK.zip
So with glscopeclient after this commit (to be checked accurately) there is a regression with corruption of "scopesession / data" which cannot be loaded/displayed correctly after save on recent version of glscopeclient

[azonenberg]

Please test if fixed by f69e6d5

[bvernoux]

The Import work but when we save the session and we try to load it again glscopeclient quit (like a crash without any details) ...
You can reproduce that with the file provided doing all the steps in my first comment
Note: If we click on History after import it does not even open ...

[azonenberg]

Yes, there is no longer any history involved as the new import flow is filter based, and filters don't have any concept of history.

I just tried in 64c7279 on Linux. Imported your rx_5us file, saved to a scopesession, then opened it. Loaded correctly, no crash, waveforms look fine.

Can you try building from source with debug symbols and running under a debugger to see if you can narrow down what's going on? Do you have access to a suitable Linux dev machine you can try on?