Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure vkFFT dependencies are correctly detected by CMake for all supported/upcoming platforms #482

Closed
azonenberg opened this issue Sep 3, 2022 · 2 comments
Closed

Make sure vkFFT dependencies are correctly detected by CMake for all supported/upcoming platforms #482

azonenberg opened this issue Sep 3, 2022 · 2 comments
Assignees
@Johnsel
Labels
build Build system and infrastructure

Comments

@azonenberg
Copy link
Collaborator

and set VKFFT_LIBRARIES or something so we don't need to add seven separate libs to every binary...
@azonenberg azonenberg added the build Build system and infrastructure label Sep 3, 2022
@azonenberg azonenberg changed the title Make sure vkFFT is correctly detected by CMake for all supported/upcoming platforms Make sure vkFFT dependencies are correctly detected by CMake for all supported/upcoming platforms Sep 6, 2022
@ehntoo
Copy link
Contributor

ehntoo commented Sep 12, 2022

Was this sufficiently addressed by ngscopeclient/scopehal@d97c287 and 36c9d06#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR58 ?

@azonenberg
Copy link
Collaborator Author

Yes, I think we're good at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Johnsel Johnsel

Labels
build Build system and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehntoo @Johnsel @azonenberg