Migrate from Gdk::Color to HTML color strings #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes accompany ngscopeclient/scopehal#710 to refactor our usage of Gdk::Color for specifying colors within scopehal. Additionally, there are a few changes to begin to move towards being able to compile ngscopeclient without GTK.
CI results from my fork, with scopehal pointed at the last commit in ngscopeclient/scopehal#710:
Ubuntu: https://github.com/ehntoo/scopehal-apps/actions/runs/3208714570/jobs/5244820709
macOS: https://github.com/ehntoo/scopehal-apps/actions/runs/3208714571/jobs/5244820704
Windows: https://github.com/ehntoo/scopehal-apps/actions/runs/3208714569/jobs/5244820702