Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Picoscope3000 series+MSO (missing AWG) #19

Merged
merged 8 commits into from Jul 24, 2022

Conversation

bvernoux
Copy link
Contributor

@bvernoux bvernoux commented Jul 10, 2022

Add support of Picoscope 3000 series (including MSO option)

…MSYS2/Mingw64 need some fixes see also TODO PICO3000A)
@bvernoux
Copy link
Contributor Author

bvernoux commented Jul 10, 2022

There is still an issue (was present in older glscopeclient when Picoscope3000 was basically supported before the refactoring) with the timebase which is wrong
image
Example capture
Horizontal scale is wrong expected signal is 1kHz/2Vp-p (Picoscope Probe compensation pin) here it is 2.5x faster (2.5KHz instead of 1KHz)
Even here with 1MS & 62.5MS/s same issue as with 100kS & 62.5MS/s
image

Update:
It is fixed in 45df1de

@azonenberg
Copy link
Collaborator

azonenberg commented Jul 10, 2022

Please ensure compliance to the project coding style (https://github.com/azonenberg/coding-policy/blob/master/cpp-coding-policy.md)

In particular, curly braces and "else" clauses live on their own line:

if(foo)
{
}
else
{
}

Do not do:

if(foo)
{
} else {
}

@bvernoux bvernoux changed the title Support Picoscope3000 series(missing AWG) for test Support Picoscope3000 series(missing AWG) Jul 10, 2022
@bvernoux bvernoux changed the title Support Picoscope3000 series(missing AWG) Support Picoscope3000 series+MSO (missing AWG) Jul 10, 2022
@azonenberg azonenberg merged commit c9a5817 into ngscopeclient:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants