Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into optimizing global #include's #297

Open
azonenberg opened this issue Oct 6, 2020 · 2 comments
Open

Look into optimizing global #include's #297

azonenberg opened this issue Oct 6, 2020 · 2 comments
Assignees
Labels
cleanup Removing cruft
Milestone

Comments

@azonenberg
Copy link
Collaborator

We have a ton of stuff in scopehal.h and scopeprotocols.h that isn't truly needed project wide. Can we reduce the scope of some individual filter class headers etc so they're not being included project-wide and slowing down the build?

@azonenberg azonenberg added the cleanup Removing cruft label Oct 6, 2020
@tarunik
Copy link
Collaborator

tarunik commented Oct 6, 2020

Do we want this to be a one-time pass, or an ongoing header-patrol effort? Either way, include-what-you-use seems like the tool for this job...

@azonenberg
Copy link
Collaborator Author

For now, a one-time pass is probably adequate.

@azonenberg azonenberg added this to the v0.2 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Removing cruft
Projects
None yet
Development

No branches or pull requests

3 participants