Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird numerical issue in emphasis removal filter #603

Closed
azonenberg opened this issue May 13, 2022 · 2 comments
Closed

Weird numerical issue in emphasis removal filter #603

azonenberg opened this issue May 13, 2022 · 2 comments
Labels
bug Something isn't working filter Filter graph blocks

Comments

@azonenberg
Copy link
Collaborator

Test data to reproduce at intel-82576-waverunner-pt5.scopesession

pcie-demo4
@azonenberg azonenberg added bug Something isn't working filter Filter graph blocks labels May 13, 2022
@azonenberg
Copy link
Collaborator Author

Appears the root cause is TappedDelayLineFilter assuming a constant delay window in samples. With spread spectrum clocks, or sample clocks that are not integer multiples of the UI, this doesn't work.

We probably need to have the tapped delay line filter take a recovered bit clock and do taps relative to that (ideally with resampling).

@azonenberg
Copy link
Collaborator Author

Not actually a bug, weird artifact in input data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working filter Filter graph blocks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azonenberg