Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: create SparseWaveform and DenseWaveform clases to replace m_densePacked #650

Closed
azonenberg opened this issue Jul 1, 2022 · 0 comments
Closed

Refactoring: create SparseWaveform and DenseWaveform clases to replace m_densePacked #650

azonenberg opened this issue Jul 1, 2022 · 0 comments
Labels
cleanup Removing cruft core

Comments

@azonenberg
Copy link
Collaborator

This eliminates the need to haul around two int64s per sample of sparsing metadata on uniformly sampled waveforms, greatly reducing (by a factor of 5:1) RAM consumed by large non-sparse waveform datasets.

Downside: requires all filters to either only support sparse/dense input, or have code paths for both possible representations of each input.
@azonenberg azonenberg added cleanup Removing cruft core labels Jul 1, 2022
azonenberg added a commit that referenced this issue Aug 27, 2022
@azonenberg
Initial work on data model revamp. See #650.
f944904
azonenberg added a commit that referenced this issue Aug 27, 2022
@azonenberg
Continued refactoring of data model, filters starting with E. See #650.
5c2216f
azonenberg added a commit that referenced this issue Aug 27, 2022
@azonenberg
Continued waveform refactoring, finished filters beginning with E. See …
53302c5 
…#650.
azonenberg added a commit that referenced this issue Aug 27, 2022
@azonenberg
Refactored filters starting with F to new data model. See #650.
17e3b9b
azonenberg added a commit that referenced this issue Aug 27, 2022
@azonenberg
Refactored filters starting with G. See #650.
dc90b88
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored filters starting with H. See #650.
d23d655
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Finished refactoring filters starting with I. See #650.
7a1b183
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored filters starting with J/K/L. See #650.
629aa9f
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored data model for filters starting with M. See #650.
10bd5c7
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactoredfilters starting with N. See #650.
00ad65c
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored filters starting with O. See #650.
544f013
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored filters starting with P. See #650.
1dbb9fd
azonenberg added a commit that referenced this issue Aug 28, 2022
@azonenberg
Refactored filters starting with Q. See #650.
9bb294b
azonenberg added a commit that referenced this issue Aug 29, 2022
@azonenberg
Refactored filters starting with R. See #650.
b618154
azonenberg added a commit that referenced this issue Aug 29, 2022
@azonenberg
Continued waveform refactor, done with filters starting with S. See #650
ca05e72 
.
azonenberg added a commit that referenced this issue Aug 29, 2022
@azonenberg
Refactored filters starting with T. See #650.
79ebe0d
azonenberg added a commit that referenced this issue Aug 29, 2022
@azonenberg
Refactored filters starting with U. See #650.
e1a0342
azonenberg added a commit that referenced this issue Aug 29, 2022
@azonenberg
Refactored filters starting with V. See #650.
85b07b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Removing cruft core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azonenberg