Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: make GetText() / GetColor() methods of a waveform #663

Closed
azonenberg opened this issue Aug 6, 2022 · 0 comments · Fixed by #669
Closed

Refactoring: make GetText() / GetColor() methods of a waveform #663

azonenberg opened this issue Aug 6, 2022 · 0 comments · Fixed by #669
Assignees
@602p
Labels
api API improvements cleanup Removing cruft

Comments

@azonenberg
Copy link
Collaborator

This allows multiple types of decode or instrument to output e.g. an 8b10b or PCIe waveform and have it decode properly without duplicated code.

Also is required to enable protocol analyzers to output protocol-type waveforms.
@azonenberg azonenberg added api API improvements cleanup Removing cruft labels Aug 6, 2022
@azonenberg azonenberg linked a pull request Aug 20, 2022 that will close this issue
Refactor GetText/GetColor to be properties on protocol waveforms #669
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@602p 602p

Labels
api API improvements cleanup Removing cruft
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor GetText/GetColor to be properties on protocol waveforms 602p/scopehal
2 participants
@azonenberg @602p