Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of non-portable functions/headers #711

Closed
3 tasks
ehntoo opened this issue Oct 8, 2022 · 2 comments · Fixed by #712
Closed
3 tasks

Remove usages of non-portable functions/headers #711

ehntoo opened this issue Oct 8, 2022 · 2 comments · Fixed by #712

Comments

@ehntoo
Copy link
Contributor

ehntoo commented Oct 8, 2022

Several places in the codebase make use of POSIX headers and functions (e.g. unistd.h, fcntl.h, and dirent.h). These will make a straight windows port more difficult and should be removed.

An incomplete list:

@azonenberg
Copy link
Collaborator

SCPITMCTransport should be entirely ifdef'd in its current form; it relies on the Linux /dev/usbtmc kernel driver and is not usable on any other platform.

See #519.

@azonenberg
Copy link
Collaborator

SCPINullTransport does not even call any functions from these headers, likely copy-paste bug. So that's trivial to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants