We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On windows (including msys2 mingw64), sizeof(int)==sizeof(long)==4. stol will then overflow when parsing periods larger than 2us (< 500Kkz). https://github.com/glscopeclient/scopehal/blob/master/scopehal/DigilentOscilloscope.cpp#L456C10-L456C10
sizeof(int)==sizeof(long)==4
stol
Replacing stol with stoll fixes windows build, but is a bit of overkill on normal systems (128 bits)
stoll
The text was updated successfully, but these errors were encountered:
Yes just replace it with std::stoll() it returns a 64bits (long long) on any 64bits computer and not 128bits You can push a PR for that
Sorry, something went wrong.
#802
No branches or pull requests
On windows (including msys2 mingw64),
sizeof(int)==sizeof(long)==4
.stol
will then overflow when parsing periods larger than 2us (< 500Kkz).https://github.com/glscopeclient/scopehal/blob/master/scopehal/DigilentOscilloscope.cpp#L456C10-L456C10
Replacing
stol
withstoll
fixes windows build, but is a bit of overkill on normal systems (128 bits)The text was updated successfully, but these errors were encountered: