Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Siglent SDS2000X Plus] Fix ADC mode setting; Fix slow 10-bit data acquisition with newer firmware #785

Merged

Conversation

hansemro
Copy link
Contributor

@hansemro hansemro commented Jul 24, 2023

Fixes #784.

Tasks:

  • Add delays to set :WAV:WIDTH
  • Replace invalid queries on set commands
  • Skip data size workaround for firmware versions 1.3.9R10 and newer.
    • I currently assume data size bug is present in versions 1.3.9R6 and older.
  • Get confirmation that the size bug is or is not present in versions older than 1.3.9R6.
  • Test from another SDS2000X Plus user.

…ands

We do not expect a reply from `:WAVEFORM:WIDTH <BYTE|WORD>` set command.

This fixes some minor slowdowns when getting/setting ADC resolution.
This fixes a SDS2000X Plus bug where :WAVEFORM:WIDTH does not change
when setting a different ADC mode.

Tested bug in firmware versions 1.3.9R10 and 1.5.2R3.
… 1.3.9R10+

This resolves read timeouts on SDS2000X Plus running firmware version
1.3.9R10 and newer. Presumably, Siglent fixed the data size issue
reported on 1.3.9R6.
@hansemro hansemro marked this pull request as ready for review October 1, 2023 21:46
@azonenberg azonenberg merged commit 579683c into ngscopeclient:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Siglent SDS2000X Plus] Partially broken 8/10-bit mode switching; Slow data acquisition in 10-bit mode
2 participants