Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainging return type of INSERT #70

Closed
panarch opened this issue Sep 14, 2020 · 1 comment · Fixed by #71
Closed

Chainging return type of INSERT #70

panarch opened this issue Sep 14, 2020 · 1 comment · Fixed by #71
Labels
enhancement New feature or request
Projects
v0.2
Milestone
v0.2

Comments

@panarch
Copy link
Member

panarch commented Sep 14, 2020 •
edited

Current

Payload::Insert(Vec<Row>)

Expected

Payload::Insert(usize)

Let's simply return a number of inserted rows.
@panarch panarch added the enhancement New feature or request label Sep 14, 2020
@panarch panarch added this to the v0.2 milestone Sep 14, 2020
@panarch panarch mentioned this issue Sep 14, 2020
Merged
@panarch
Copy link
Member Author

panarch commented Sep 14, 2020

I linked the wrong issue, not #68, it is related to #69.

@ryanhossain9797 ryanhossain9797 mentioned this issue Sep 14, 2020
Merged
@panarch panarch mentioned this issue Sep 14, 2020
Closed
@panarch panarch added this to Done in v0.2 Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
v0.2
  
Done
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Return row count instead of rows on Insert ryanhossain9797/gluesql
1 participant
@panarch