Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 6714ac6 broke Windows compatibility #7

Closed
glumia opened this issue Nov 25, 2018 · 1 comment
Closed

Commit 6714ac6 broke Windows compatibility #7

glumia opened this issue Nov 25, 2018 · 1 comment

Comments

@glumia
Copy link
Owner

glumia commented Nov 25, 2018

Commit 6714ac6 broke windows compatibility.
If the user gives a folder as third argument the script should check what's the environment and then eventually add a '\' if we are on Windows and a '/' if we are on Unix.

Example output:

C:\Users\gius\Desktop\openload-dl-master>python openload-dl "https://oload.fun/f/5HHWrGijP7U/Naruto_001.mp4" C:\User\gius\Desktop
Extracting download link for C:\User\gius\Desktop/Naruto 001.mp4
Download of C:\User\gius\Desktop/Naruto 001.mp4 in progress...
Traceback (most recent call last):
  File "openload-dl", line 74, in <module>
    with open(filename,'wb') as fp:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\User\\gius\\Desktop/Naruto 001.mp4'
@glumia glumia changed the title Commit 6714ac64b082234d585cb30a7d71afe430ef7e93 broke Windows compatibility Commit 6714ac6 broke Windows compatibility Nov 25, 2018
@glumia
Copy link
Owner Author

glumia commented Nov 26, 2018

Solved with commit 7db3800.
If the user wants to download the file in a particular folder he can specify the full path with '-o' option.

@glumia glumia closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant