oVirt single node hyperconverged fails after changing gluster commands to CLI

[bpbp-boop]

After #54 setting up a single node fails on the following steps

Create the GlusterFS volumes
Set virt to gluster volume

In my testing changing "Create the GlusterFS volumes" to only use the replica option if it's defined and skipping the "Set virt" step for a single host allows the set up to finish

[lachlan2k]

I experienced this too. Here are my logs:

> TASK [gluster.features/roles/gluster_hci : Create the GlusterFS volumes] *******
> failed: [ovirt1.virtlab.local] (item={'volname': 'engine', 'brick': '/gluster_bricks/engine/engine', 'arbiter': 0}) => {"ansible_loop_var": "item", "changed": true, "cmd": "gluster volume create engine replica __omit_place_holder__271309670af5fb5cca7c409d606e6bb02ff56086  transport tcp  ovirt1.virtlab.local:/gluster_bricks/engine/engine  force\n", "delta": "0:00:00.099517", "end": "2022-05-18 19:06:24.945444", "item": {"arbiter": 0, "brick": "/gluster_bricks/engine/engine", "volname": "engine"}, "msg": "non-zero return code", "rc": 1, "start": "2022-05-18 19:06:24.845927", "stderr": "replica count should be greater than 1\n\nUsage:\nvolume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]", "stderr_lines": ["replica count should be greater than 1", "", "Usage:", "volume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]"], "stdout": "", "stdout_lines": []}
> failed: [ovirt1.virtlab.local] (item={'volname': 'data', 'brick': '/gluster_bricks/data/data', 'arbiter': 0}) => {"ansible_loop_var": "item", "changed": true, "cmd": "gluster volume create data replica __omit_place_holder__271309670af5fb5cca7c409d606e6bb02ff56086  transport tcp  ovirt1.virtlab.local:/gluster_bricks/data/data  force\n", "delta": "0:00:00.100561", "end": "2022-05-18 19:06:25.446181", "item": {"arbiter": 0, "brick": "/gluster_bricks/data/data", "volname": "data"}, "msg": "non-zero return code", "rc": 1, "start": "2022-05-18 19:06:25.345620", "stderr": "replica count should be greater than 1\n\nUsage:\nvolume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]", "stderr_lines": ["replica count should be greater than 1", "", "Usage:", "volume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]"], "stdout": "", "stdout_lines": []}
> failed: [ovirt1.virtlab.local] (item={'volname': 'vmstore', 'brick': '/gluster_bricks/vmstore/vmstore', 'arbiter': 0}) => {"ansible_loop_var": "item", "changed": true, "cmd": "gluster volume create vmstore replica __omit_place_holder__271309670af5fb5cca7c409d606e6bb02ff56086  transport tcp  ovirt1.virtlab.local:/gluster_bricks/vmstore/vmstore  force\n", "delta": "0:00:00.100282", "end": "2022-05-18 19:06:25.946400", "item": {"arbiter": 0, "brick": "/gluster_bricks/vmstore/vmstore", "volname": "vmstore"}, "msg": "non-zero return code", "rc": 1, "start": "2022-05-18 19:06:25.846118", "stderr": "replica count should be greater than 1\n\nUsage:\nvolume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]", "stderr_lines": ["replica count should be greater than 1", "", "Usage:", "volume create <NEW-VOLNAME> [[replica <COUNT> [arbiter <COUNT>]]|[replica 2 thin-arbiter 1]] [disperse [<COUNT>]] [disperse-data <COUNT>] [redundancy <COUNT>] [transport <tcp|rdma|tcp,rdma>] <NEW-BRICK> <TA-BRICK>... [force]"], "stdout": "", "stdout_lines": []}

Looks like the issue is that parameters aren't being omitted properly. E.g.

"cmd": "gluster volume create engine replica __omit_place_holder__271309670af5fb5cca7c409d606e6bb02ff56086 transport tcp ovirt1.virtlab.local:/gluster_bricks/engine/engine force\n",

Hoping for a quick fix as this has broken how I deploy certain things.

[bpbp-boop]

Fixed by #56, thank you!