Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend setup is not idempotent. #51

Closed
kristvanbesien opened this issue Jan 23, 2019 · 3 comments
Closed

backend setup is not idempotent. #51

kristvanbesien opened this issue Jan 23, 2019 · 3 comments

Comments

@kristvanbesien
Copy link

kristvanbesien commented Jan 23, 2019

The backend setup process is not idempotent.

How to reproduce:

  • Create a playbook with the gluster.infra role. (and setup the needed variables)
  • Run the playbook. Playbook succeeeds.
  • Run the playbook a second time.

Expected result:

  • Playbook succeeds second time along

Actual result:

  • Playbook fails during the xfs filesystem creation.

Running the playbook with --skip-tages=fscreate is possible as a workaround, but is not optimal.

@sac
Copy link
Member

sac commented Jan 24, 2019

The backend setup process is not idempotent.

Thanks for reporting this. I was able to debug this issue.
The `force' by default in: https://github.com/gluster/gluster-ansible-infra/blob/master/roles/backend_setup/tasks/fscreate.yml#L25 was causing the issue.

It was forcing the module to re-run the mkfs.xfs whether filesystem was already present or not.

PR: https://github.com/gluster/gluster-ansible-infra/pull/52/files fixes the issue.

@sac
Copy link
Member

sac commented Jan 24, 2019

@kristvanbesien request to review #52 if you have some time.

@sac
Copy link
Member

sac commented Jan 24, 2019

PR: #52 resolves this issue.

@sac sac closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants