Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Revisit option name that turns on xlators #376

Closed
prashanthpai opened this issue Sep 22, 2017 · 3 comments
Closed

Revisit option name that turns on xlators #376

prashanthpai opened this issue Sep 22, 2017 · 3 comments
Assignees
Labels
FW: Volgen GCS/beta0 GCS/1.0 Issue is blocker for Gluster for Container Storage priority: medium

Comments

@prashanthpai
Copy link
Contributor

The xlator option table can also contain options that load (add to graph) or turn on an xlator. For example, to turn on the barrier xlator, as of today, one has to set option named barrier.barrier to on. This should rather simply be just barrier. IOW, we need a way to identify such options. One approach is to let xlators themselves define which option in option table is a "gobal switch" resulting in the xlator itself being turned on. We can use the newly introduced flags field in the volume_option_t struct.

@amarts
Copy link
Member

amarts commented Sep 22, 2017

I was thinking of solving it by approach mentioned in gluster/glusterfs#304 Can you check if that solves your problem?

@atinmu atinmu added this to the mvp-3 milestone Nov 28, 2017
@atinmu atinmu removed this from the mvp-3 milestone Jun 23, 2018
@atinmu atinmu added Gluster 4.2 GCS/1.0 Issue is blocker for Gluster for Container Storage labels Jun 23, 2018
@prashanthpai prashanthpai added GCS/1.0 Issue is blocker for Gluster for Container Storage and removed GCS/1.0 Issue is blocker for Gluster for Container Storage labels Jul 26, 2018
@atinmu atinmu added this to the GCS-beta0 milestone Sep 27, 2018
@aravindavk
Copy link
Member

With the templates support for Volgen(#1229). A Xlator can be enabled by setting [<graph-name>].<option-name>=on in Volinfo. (Volume Set/Reset need to be accommodated once template support merges)

Some Xlators understands enable by having a option in the graph as below,

volume gv7-changelog
    type features/changelog
    option changelog on
    subvolumes gv7-changetimerecorder
end-volume

And some of the Xlators doesn't need any option to say it is enabled. If xlator present in volfile means enabled. This can be handled by setting EnabledByOption field in Volfile template.

@aravindavk
Copy link
Member

With Glusterfs Patch https://review.gluster.org/21813 and Glusterd2 patch #1370 we can enable/disable xlators if option name with same name as xlator exists in respective options table.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FW: Volgen GCS/beta0 GCS/1.0 Issue is blocker for Gluster for Container Storage priority: medium
Projects
None yet
Development

No branches or pull requests

5 participants