Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug:1594857] Make smoke runs detect test cases added to patch #3

Open
gluster-ant opened this issue Mar 12, 2020 · 2 comments
Open

Comments

@gluster-ant
Copy link
Collaborator

URL: https://bugzilla.redhat.com/1594857
Creator: atumball at redhat
Time: 20180625T14:38:54

Description of problem:

Today, there is no validation of test cases 'per patch'. Specially for features being added to codebase.

I would propose we need .t file being changed in patch, or else, a commit message should have a section called "Testind done:" (can be added as a check in ./rfc.sh) which would vote +1, or else, it would vote -1.

Additional info:

Technically speaking, if the patch has only .testignore files, then this test may not vote, so smoke will go ahead with all other tests.

@gluster-ant
Copy link
Collaborator Author

Time: 20180625T14:39:54
atumball at redhat commented:
We need public announcement of this before making this change in process.

@gluster-ant
Copy link
Collaborator Author

Time: 20181005T08:47:48
nigelb at redhat commented:
Getting smoke to fail if there's no .t file is not hard. But there are a lot of patches where we're fixing Coverity or static analysis failures where this will be more nuisance than useful. Should this be yet another flag like Spec Added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant