You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today, there is no validation of test cases 'per patch'. Specially for features being added to codebase.
I would propose we need .t file being changed in patch, or else, a commit message should have a section called "Testind done:" (can be added as a check in ./rfc.sh) which would vote +1, or else, it would vote -1.
Additional info:
Technically speaking, if the patch has only .testignore files, then this test may not vote, so smoke will go ahead with all other tests.
The text was updated successfully, but these errors were encountered:
Time: 20181005T08:47:48
nigelb at redhat commented:
Getting smoke to fail if there's no .t file is not hard. But there are a lot of patches where we're fixing Coverity or static analysis failures where this will be more nuisance than useful. Should this be yet another flag like Spec Added?
URL: https://bugzilla.redhat.com/1594857
Creator: atumball at redhat
Time: 20180625T14:38:54
Description of problem:
Today, there is no validation of test cases 'per patch'. Specially for features being added to codebase.
I would propose we need .t file being changed in patch, or else, a commit message should have a section called "Testind done:" (can be added as a check in ./rfc.sh) which would vote +1, or else, it would vote -1.
Additional info:
Technically speaking, if the patch has only .testignore files, then this test may not vote, so smoke will go ahead with all other tests.
The text was updated successfully, but these errors were encountered: