Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Field History] Incompatibility with Anki 23.x #201

Open
6 tasks done
srustamo opened this issue Mar 1, 2024 · 2 comments · May be fixed by #202
Open
6 tasks done

[Field History] Incompatibility with Anki 23.x #201

srustamo opened this issue Mar 1, 2024 · 2 comments · May be fixed by #202
Labels
bug Something isn't working

Comments

@srustamo
Copy link

srustamo commented Mar 1, 2024

Problem description

Please describe the issue concisely in here. In case of an error: Walk us through the steps you took to get there. What happened? What did you expect to happen?

Checklist

Please replace the space inside the brackets with an x if the following items apply:

  • I've restarted Anki to see if it helps
  • I've verified that I use the latest version of the add-on by redownloading it from AnkiWeb
  • I've verified that I use the latest version of Anki by checking at https://apps.ankiweb.net#download
  • I've tried to disable other add-ons to see if there are any interactions present
  • My issue disappears when I hold shift while starting Anki.
  • I've checked if anyone else reported this problem before by looking through the issue reports. I also checked to see if there is a section about known issues in the add-on description, documentation, or README.

Information about your Anki set-up

Please open Anki, go to Help → About, click on "Copy Debug Info", and paste the result between the backticks below (if the button does not appear you are using an older version of Anki 2.1 and will need to update first):

Anki 23.12.1 (1a1d4d54)  (ao)
Python 3.9.15 Qt 5.14.2 PyQt 5.14.1
Platform: macOS-10.15.7-x86_64-i386-64bit

Traceback (most recent call last):
  File "aqt.webview", line 50, in cmd
  File "aqt.webview", line 157, in _onCmd
  File "aqt.webview", line 680, in _onBridgeCmd
  File "_aqt.hooks", line 5415, in __call__
  File "/Users/srmbp1/Library/Application Support/Anki2/addons21/1771074083/web_bridge.py", line 88, in bridge
    ret = self._handle_message(message, context)
  File "/Users/srmbp1/Library/Application Support/Anki2/addons21/1771074083/web_bridge.py", line 114, in _handle_message
    return self._command_handler(command, payload, context)
  File "/Users/srmbp1/Library/Application Support/Anki2/addons21/1771074083/web_bridge.py", line 151, in __call__
    return handler(self, payload, context)  # type: ignore
  File "/Users/srmbp1/Library/Application Support/Anki2/addons21/1771074083/web_bridge.py", line 155, in browse
    browser = aqt.dialogs.open("Browser", self._mw)
  File "aqt", line 136, in open
  File "aqt.browser.browser", line 143, in __init__
  File "aqt.browser.browser", line 532, in setupEditor
  File "aqt.editor", line 143, in __init__
  File "aqt.editor", line 196, in setupWeb
  File "anki.hooks", line 45, in runFilter
TypeError: onSetupButtons20() takes 1 positional argument but 2 were given

Traceback (most recent call last):
  File "aqt.browser.browser", line 243, in resizeEvent
  File "aqt.browser.browser", line 232, in maybe_update_layout
AttributeError: 'Browser' object has no attribute 'aspect_ratio'

===Add-ons (active)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
AnkiConnect ['2055492159', 2024-02-27T09:37, 'None', mod]
Field History ['1247884413', 2019-01-08T23:34, 'None', mod]
Review Heatmap ['1771074083', 2022-06-30T06:43, 'None', '']

===IDs of active AnkiWeb add-ons===
1247884413 1771074083 2055492159

===Add-ons (inactive)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
Customize Keyboard Shortcuts ['24411424', 2023-11-01T14:17, 'None', '']
Field AutoComplete ['511710206', 2023-02-26T05:27, 'None', mod]
Global hotkeys keyboard shortcuts ['1146841074', 2022-07-04T02:31, 'None', '']

Error message (if any)

If you've received an error message, please copy and paste it between the backticks below:

Anki encountered a problem. Please follow the troubleshooting steps.
Add-ons possibly involved: ⁨Review Heatmap⁩
@srustamo srustamo added the bug Something isn't working label Mar 1, 2024
@glutanimate
Copy link
Owner

Hi there, thanks for the report!

Although the error message mentions Review Heatmap, the actual underlying issue seems to be with Field History. If you disable that add-on, clicking on the heatmap should work again.

I will transfer this issue to Field History's repo.

@glutanimate glutanimate transferred this issue from glutanimate/review-heatmap Mar 1, 2024
@glutanimate glutanimate changed the title Cliking on a heatmap cell (day) does not open that day's cards and addon crashes [Field History] Incompatibility with Anki 23.x Mar 1, 2024
thiswillbeyourgithub added a commit to thiswillbeyourgithub/anki-addons-misc that referenced this issue Apr 3, 2024
@thiswillbeyourgithub
fix: glutanimate#201 field history thought we were old version
9b9f334 
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
@thiswillbeyourgithub thiswillbeyourgithub linked a pull request Apr 3, 2024 that will close this issue
Open
@thiswillbeyourgithub
Copy link

Btw in #202 (the version check was just failing) in 9b9f334 but ended up fixing the qt6 issue arising just afterwards in e264c7e and now it works appart from glitching the tag field. Meaning after using the history in mode "full" or "partial" the tag field is not actually properly restored and gets glitched until you close the add window.

Progress nonetheless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@srustamo @glutanimate @thiswillbeyourgithub