Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Anki 23.10 #85

Open
6 tasks
orangelover12 opened this issue Nov 1, 2023 · 7 comments · May be fixed by #86
Open
6 tasks

Not working in Anki 23.10 #85

orangelover12 opened this issue Nov 1, 2023 · 7 comments · May be fixed by #86
Assignees
Labels
bug Something isn't working

Comments

@orangelover12
Copy link

orangelover12 commented Nov 1, 2023

Problem description

Hello!
First of all, I really like this add-on and I would like to thank you.
My issue is that ANKI 23.10 version came out today and this addon does not work.
I would really appreciate it if you could update it.
Have a good day!

Checklist

Please replace the space inside the brackets with an x if the following items apply:

  • I've restarted Anki to see if it helps
  • I've verified that I use the latest version of the add-on by redownloading it from AnkiWeb
  • I've verified that I use the latest version of Anki by checking at https://apps.ankiweb.net#download
  • I've tried to disable other add-ons to see if there are any interactions present
  • My issue disappears when I hold shift while starting Anki.
  • I've checked if anyone else reported this problem before by looking through the issue reports. I also checked to see if there is a section about known issues in the add-on description, documentation, or README.

Information about your Anki set-up

Please open Anki, go to Help → About, click on "Copy Debug Info", and paste the result between the backticks below (if the button does not appear you are using an older version of Anki 2.1 and will need to update first):


Error message (if any)

If you've received an error message, please copy and paste it between the backticks below:

@orangelover12 orangelover12 added the bug Something isn't working label Nov 1, 2023
@orangelover12
Copy link
Author

Yes, I meant 23.10. I just fixed the post!

@aleksejrs
Copy link

aleksejrs commented Nov 2, 2023

Thanks, you can fix the title, too.

@glutanimate glutanimate self-assigned this Nov 2, 2023
@glutanimate glutanimate changed the title Not working in anki 2.1.10 Not working in Anki 23.10 Nov 2, 2023
@addonico
Copy link

addonico commented Nov 9, 2023

Same issue here.
WechatIMG995

Version ⁨23.10 (51a10f09)⁩
Python 3.9.15 Qt 6.5.3 PyQt 6.5.3

@ShawnO33
Copy link

Just wanted to provide the debug information, although it probably is easy to reproduce and different on other devices.
When loading Pop-up Dictionary:
Traceback (most recent call last):
File "aqt.addons", line 244, in loadAddons
File "/Users/User/Library/Application Support/Anki2/addons21/popup_dictionary/init.py", line 35, in
from ._addon import * # noqa: F401, F403
File "/Users/User/Library/Application Support/Anki2/addons21/popup_dictionary/_addon.py", line 40, in
from .reviewer import initialize_reviewer
File "/Users/User/Library/Application Support/Anki2/addons21/popup_dictionary/reviewer.py", line 39, in
from PyQt5.QtGui import QKeySequence
ModuleNotFoundError: No module named 'PyQt5'

@Foxy-null
Copy link

Foxy-null commented Dec 27, 2023

I have made this add-on work with PyQt6 and describe how to do it below.

How to reproduce

  • 1. use enum converter tool in the addon folder.
  • 2. Replace all "PyQt5" words to "PyQt6". (I recommend using VSCode for bulk replacement.)
  • 3. In "reviewer.py", import QShortcut modules from aqt.qt instead of from QtWidgets
# before

from PyQt6.QtWidgets import QMenu, QShortcut

# after

from PyQt6.QtWidgets import QMenu

...

from aqt.qt import QShortcut

I have previously customized the code for this add-on file myself, so I apologize if this fix does not help.

( Edit: or just download patched addon file from here )

@Foxy-null
Copy link

I checked that above procedures work with original pop-up dictionary code. I'll create pull request for this soon.

@Foxy-null Foxy-null linked a pull request Dec 27, 2023 that will close this issue
8 tasks
@Foxy-null
Copy link

Foxy-null commented Jan 27, 2024

Seems like it's already available as Patreon content.

URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants