Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Missing JSON(Response) #14

Closed
jschristie opened this issue May 14, 2017 · 2 comments
Closed

Missing JSON(Response) #14

jschristie opened this issue May 14, 2017 · 2 comments
Assignees

Comments

@jschristie
Copy link
Contributor

nynymike commented on Jun 29 2015

Is this a problem in the Swagger --> Markdown generation? I don't see the response and error codes.

https://cloud.githubusercontent.com/assets/3717101/8410259/a3e0c30c-1e42-11e5-8408-699853dc6123.png

@nynymike nynymike changed the title from Missing Response and Error Codes to Missing Response JSON(Response) on Jun 29 2015

@nynymike nynymike changed the title from Missing Response JSON(Response) to Missing JSON(Response) on Jun 29 2015

@qbert2k qbert2k was assigned by nynymike on Jun 29 2015

@yuriyz

Add your reaction

Edit comment
Delete comment
Owner This user is the owner of the docs-2.4.4-old repository.
yuriyz commented on Jun 29 2015

those codes are hidden deeply in our code. Swagger have no idea about it. We should link it, so swagger can pick it up or otherwise write down it directly in annotation (which is bad because it will duplicate what is already in code anyway).

@yuriyz yuriyz assigned yuriyz and unassigned qbert2k on Jul 15 2015

@yuriyz yuriyz added a commit that referenced this issue on Jul 15 2015

@yuriyz docs #21 : added error codes to oic-authorization e998e07

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 15 2015

@yuriyz Authorize WS : added error codes for swagger docs https://github.com/…

151f49f

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 15 2015

@yuriyz Token WS : added error codes for swagger docs https://github.com/Gluu…

a6956c3

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 15 2015

@yuriyz Token WS : added error codes for swagger docs https://github.com/Gluu…

cdedf99

@yuriyz yuriyz added a commit that referenced this issue on Jul 15 2015

@yuriyz docs #21 : added error codes to oic-token f1aec75

@yuriyz

Add your reaction

Edit comment
Delete comment
Owner This user is the owner of the docs-2.4.4-old repository.
yuriyz commented on Jul 15 2015

@nynymike I've checked swagger implementation and according to their implementation it not possible to inline error codes from code. We have to inline it in swagger annotations directly.
https://github.com/swagger-api/swagger-core/wiki/Annotations

I will do following:
1.put error code directly in swagger annotations in oxauth code
2.regenerate markdown
3.update it in docs

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 15 2015

@yuriyz User Info WS : added error codes for swagger docs https://github.com/…

593a7d3

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 15 2015

@yuriyz Register Client WS : added error codes for swagger docs https://githu…

8e5d529

@yuriyz yuriyz added a commit that referenced this issue on Jul 15 2015

@yuriyz User Info docs #21 - updated error codes bef3f32

@yuriyz yuriyz added a commit that referenced this issue on Jul 15 2015

@yuriyz Register Client docs #21 - updated error codes 6146519

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 16 2015

@yuriyz End session WS : added error codes for swagger docs https://github.co…

e6298b9

@yuriyz yuriyz added a commit that referenced this issue on Jul 16 2015

@yuriyz End Session WS docs #21 - updated error codes a918857

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem Authorize WS : added error codes for swagger docs https://github.com/…

ce1a4cd

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem Token WS : added error codes for swagger docs https://github.com/Gluu…

78400ce

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem Token WS : added error codes for swagger docs https://github.com/Gluu…

495a605

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem User Info WS : added error codes for swagger docs https://github.com/…

890fa44

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem Register Client WS : added error codes for swagger docs https://githu…

84cfc5d

@yuriyz yuriyz referenced this issue in GluuFederation/oxAuth on Jul 23 2015

@yuriyz @yurem End session WS : added error codes for swagger docs https://github.co…

Re-creating from old repo, since old repos are removed***

@jschristie
Copy link
Contributor Author

no idea whether swagger is still used in newer version, however adding to track

@jschristie
Copy link
Contributor Author

Have added content to JSON response in the new version. Hence closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants