/etc/profile.d/bundler-exec.sh script breaks GNOME desktop on Arch Linux

[ed-torvalds]

Your package bundler-exec (version latest-1) provides a fault script /etc/profile.d/bundler-exec.sh because of which I was not able to login to GNOME 3.20 on Arch Linux. More details: https://bbs.archlinux.org/viewtopic.php?id=211284
You must know that all the scripts in /etc/profile.d directory are run by sh at the time of login in GDM (usually because bash or zsh are default shell). sh shell does not allow - in the name of identifiers, so I get this error

Apr 13 14:36:59 ArchLinux /usr/lib/gdm/gdm-x-session[2719]: /etc/profile.d/bundler-exec.sh: line 12: `bundler-installed': not a valid identifier

you should please fix this problem asap :-) I have installed this package from https://aur.archlinux.org/packages/bundler-exec/
Fixing it requires to remove - from all identifiers

[gma]

Thanks for the report, but it's not intended to be dropped into a system wide folder (and I consider doing so – magically redefining a bunch of Ruby scripts for all users – a bad idea).

[ed-torvalds]

so what fix you are going to do in your package?

[gma]

What gave you the impression it's my package? I don't think this script is a good candidate for being packaged at all.

[gma]

Also, when you do identify the author of the package, I suggest trying not to sound so demanding (eg "fix it asap" and "so what are you going to do?"). Don't forget that people share this stuff for free, on their own time.

Have you considered fixing it yourself, then sharing the result?

[gma]

Also, when you do identify the author of the package, I suggest trying not to sound so demanding (eg "fix it asap" and "so what are you going to do?"). Don't forget that people share this stuff for free, on their own time.

Have you considered fixing it yourself, then sharing the result?

[ed-torvalds]

I wasn't being demanding did you notice the word please, and I used the word asap because this problem might affect many no. of people, so to stop them from being frustrated.

[gma]

Take it as feedback as to how you came across.

Sure, you said please. If that's why you said asap it was redundant – of course other people may be affected if it's in a distro. That's implicitly obvious.

Why you said it isn't really relevant. It's inappropriately pushy. I'm not having a go (or annoyed), I'm just aware that you could rub some people up the wrong way with that approach, and you might not realise it if nobody points it out.