Add partial support for 3D related conv/pooling/padding #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jiayiliu! Thank you for your pull request. |
gmalivenko
reviewed
Jan 16, 2020
gmalivenko
reviewed
Jan 16, 2020
gmalivenko
reviewed
Jan 16, 2020
|
Changed accordingly. I didn't run reformat the code on my end because my default setting replaces 'single quote' by "double quote". I hope |
|
Hey! Sorry for a big delay, I'll review & merge your changes soon. Once again, thank you for your work. |
|
Merged, thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Nice work, and I found it quite useful.
I would like to push some changes for 3d conv/padding/pooling.
Not all functions are support but is sufficient for my purpose so far.
Hope you can accept the request.
Cheers,