Prevent pan gesture recognizer to start when panning is disabled #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice. Is the check at still needed?Or will your addition prevent the method from being triggered entirely? If so, can you remove the |
|
The check is indeed not needed anymore. The addition will prevent the method from being triggered entirely. Let me do the change. |
It also allow scrolling when the better segmented control is placed inside a scroll view and the panning is disabled on the segmented control
gmarm
approved these changes
Dec 12, 2019
|
Cool, thanks for taking the time to add this @Valgrin ! |
|
Thank you @gmarm for your reactivity! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent pan gesture recognizer to start when panning is disabled
It also allow scrolling when the better segmented control is placed inside a scroll view and the panning is disabled on the segmented control