Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add announceImmediately property #21

Closed
wants to merge 1 commit into from
Closed

add announceImmediately property #21

wants to merge 1 commit into from

Conversation

cannyboy
Copy link

@cannyboy cannyboy commented Jul 28, 2016

It sometimes makes sense to trigger .ValueChanged on tap, rather than wait for the control to slide into place. The announceImmediately property does this.

(please ignore the podfile stuff)

@gmarm
Copy link
Owner

gmarm commented Sep 14, 2016

Apologies for my late response, I didn't have much time lately.

This indeed makes much sense!!

However there are some things that need to be done first. Pull master branch to resolve conflicts and revert all the changes in unnecessary files and push again. The only files changed should be the control and view controller files. Also, instead of adding a new control as an example to showcase the change, edit the first example ("Lights on / off").

If you're not up for it just close this PR and I'll implement this myself. Cheers.

@cannyboy
Copy link
Author

ok, i'll see if i can do that

@cannyboy
Copy link
Author

#26

@gmarm
Copy link
Owner

gmarm commented Dec 17, 2016

Merged in #26.

@gmarm gmarm closed this Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants