Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join on empty dataframe returns an array instead of an empty dataset #54

Closed
fgutmann opened this issue May 22, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@fgutmann
Copy link

When joining with an empty dataframe the result is an array.
I'd expect it to be an empty dataframe.

Example:

let df1 = new dfjs.DataFrame([]);
let df2 = new dfjs.DataFrame([]);
df1.join(df2, 'col1'); // empty array

The empty array is quite unhandy in situations where filter() is followed by join().
What are your thoughts on this?

@Gmousse Gmousse self-assigned this May 22, 2018
@Gmousse Gmousse added the bug label May 22, 2018
@Gmousse
Copy link
Owner

Gmousse commented May 22, 2018

Hum it's clearly a bug.
thanks @fgutmann I will see for a fix when I can find some free time.

@Gmousse Gmousse added this to the 1.3.2 milestone May 24, 2018
@Gmousse Gmousse mentioned this issue May 24, 2018
@Gmousse
Copy link
Owner

Gmousse commented May 24, 2018

It was fixed on this PR.

I will investigate on other reduce / groupBy issues with empty (or with one element) DataFrame.

I hope a release on monday.

@fgutmann
Copy link
Author

Thanks for being that fast 👍
A release would would be awesome too!

@Gmousse
Copy link
Owner

Gmousse commented May 30, 2018

Fixed and published in 1.3.2

@Gmousse Gmousse reopened this May 30, 2018
@Gmousse Gmousse closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants