Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to watchlist not showing #134

Open
skgupta507 opened this issue May 17, 2024 · 7 comments
Open

Add to watchlist not showing #134

skgupta507 opened this issue May 17, 2024 · 7 comments

Comments

@skgupta507
Copy link

hey @gneiru the _add to watchlist _ button is not showing on my deployment can u help me with this error pls.
i have attached screenshot of it.

image

@gneiru
Copy link
Owner

gneiru commented May 17, 2024

Oh, it seems you have to change the email address here. Afterwards insert the series you want in db via button

if (sess?.user.email !== "noelrohi59@gmail.com") return null;

@skgupta507
Copy link
Author

Oh, it seems you have to change the email address here. Afterwards insert the series you want in db via button

if (sess?.user.email !== "noelrohi59@gmail.com") return null;

Hi so if i change the email it will work for me.
but i have a doubt .......... if i use my mail id instead of urs it will work for me. but what about other users using my deployment. will it work for them also.

@gneiru
Copy link
Owner

gneiru commented May 17, 2024

It is supposed to be accessible only by the admin. But if you want all users, you can remove that line of code

@skgupta507
Copy link
Author

It is supposed to be accessible only by the admin. But if you want all users, you can remove that line of code

what i meant was is it not possible for the users to add the series to thier watchlist instead of the admin creating the database n then allowing the users to add thier own.
cant it be added directly.
like it will be lot of work to add every available series to the database right.

@gneiru
Copy link
Owner

gneiru commented May 17, 2024

Currently, they cannot add series in their watchlist that are not inserted in database.

Why?

Once the user add something in watchlist, the app will not know the image and title because it only saves its slug (identifier)

Why not insert the image and title upon adding watchlist?

I have thoughts about this before, but since we are also upserting drama series in the database, imo it is better to just query the watchlist and join related series connected thru the slug.

Since the button is not only for inserting drama data, it also updates the data (if already inserted) when there are changes in the series details e.g title, image, number of episodes

Advantages of doing this will match the drama details in home page even after the user added the series in their watchlist.

@gneiru
Copy link
Owner

gneiru commented May 17, 2024

And yes this watchlist thing needs improvement, let me know what you think.

@skgupta507
Copy link
Author

skgupta507 commented May 17, 2024

And yes this watchlist thing needs improvement, let me know what you think.

do u use Discord or have a Discord server where we can share our suggestions n all that.
or other socials we can connect with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants