Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use search in channel ! #27

Closed
AizeLeOuf opened this issue Jan 29, 2020 · 6 comments
Closed

Can't use search in channel ! #27

AizeLeOuf opened this issue Jan 29, 2020 · 6 comments
Labels

Comments

@AizeLeOuf
Copy link
Contributor

According to https://api.mattermost.com/#tag/channels%2Fpaths%2F~1teams~1%7Bteam_id%7D~1channels~1search%2Fpost

a HTTP Post was expected but in the code there is a get :

return $this->client->get(TeamModel::$endpoint . '/' . $teamId . self::$endpoint . '/search', $requestOptions);

About that, can't find an example, to inject data in post body.. :'( can you provide an example for that ?

Best regards,

And many thanks to share your work !

@gnello
Copy link
Owner

gnello commented Jan 29, 2020

Hi!
Thanks for your contribution on this error!

This issue was solved (by you 😄 ) in #28.

I'm going to provide an example in the readme, thanks for pointing that out.

@gnello
Copy link
Owner

gnello commented Jan 29, 2020

I've just added this example in the readme:

//Search a channel
$result = $driver->getChannelModel()->searchChannels($teamId, [
    'term' => "full or partial name or display name of channels"
]);

Let me know if it helps.

@AizeLeOuf
Copy link
Contributor Author

AizeLeOuf commented Jan 30, 2020

Just perfect !! Many thanks :)

Another last question, have you plan to support methods added in >5, for example https://api.mattermost.com/#tag/channels%2Fpaths%2F~1channels~1%7Bchannel_id%7D~1privacy%2Fput ?

@gnello
Copy link
Owner

gnello commented Jan 30, 2020

Sure, I'm going to add support for all new method as soon as I can, I hope I can do it even this weekend.

I'll keep you updated.

@gnello
Copy link
Owner

gnello commented Feb 2, 2020

Hi,
I've just released the 2.10.0 version that it should be up to date with the current version of mattermost server.
Let me know if you notice any inaccuracies.

Thanks.

@gnello
Copy link
Owner

gnello commented Feb 26, 2020

Hi,
I'm closing this issue assuming everything's ok 🙂.
Please, open a new issue if you have any further requests.

Thank you!

@gnello gnello closed this as completed Feb 26, 2020
@gnello gnello added the bug label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants