enum gets downcasted to uint8

[gosuto-inzasheru]

gnosis' Delay contract contains an Enum.Operation that when generating the interface simply gets reduced to a uint8.

why is there no proper declaration of the Operation enum included in the interface?

[gnidan]

Sounds like a bug, or possibly the input ABI JSON is missing the necessary internalType information.

Apologies that I'm going out of town for a few days, but I will look into this when I get back next week.

Thanks for raising this!

[gosuto-inzasheru]

the abi does contain internalType data, eg:

{
  "inputs": [
    { "internalType": "address", "name": "to", "type": "address" },
    { "internalType": "uint256", "name": "value", "type": "uint256" },
    { "internalType": "bytes", "name": "data", "type": "bytes" },
    {
      "internalType": "enum Enum.Operation",
      "name": "operation",
      "type": "uint8"
    }
  ],
  "name": "execTransactionFromModule",
  "outputs": [{ "internalType": "bool", "name": "success", "type": "bool" }],
  "stateMutability": "nonpayable",
  "type": "function"
}

[gnidan]

Oh, right! I remember now - this tool hasn't been able to support enums because the ABI JSON does not encode the values of the enum. This would have to be a new feature to allow you to specify these values, separately from the ABI JSON.

Kind of annoying, sorry :/

[gosuto-inzasheru]

a feature as in a feature in the abi standard or as in a feature in the abi-to-sol tool?

[gnidan]

Feature in abi-to-sol - like on the web UI, imagine new text boxes to specify extra info (or a flag on the CLI)

This might be something that could be added to the ABI JSON itself, but that would require Solidity to agree to add it, and then it wouldn't exist for older contracts anyway.

[gosuto-inzasheru]

i see; the abi json is the limitation here

my use case would require this to be available in the cli version of the app, but i understand that that wont be possible either way (unless the abi json standard is amended)

feel free to close :)

[gnidan]

Yeah, sorry that it's not easier.

I'll keep this issue open... I'd like to address this someday, and this issue will remind me :)

Thanks again!