Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User changing HipChat name will lose all stats #2

Open
gnjack opened this issue Jan 5, 2018 · 0 comments
Open

User changing HipChat name will lose all stats #2

gnjack opened this issue Jan 5, 2018 · 0 comments

Comments

@gnjack
Copy link
Owner

gnjack commented Jan 5, 2018

The lower-cased name of a user is currently used as the key for that player & their matches in the DB.
This was to ensure we can support players who do not have a HipChat account (so can't use HipChat user ID).

Could be fixed by adding a rename command, this would need to update the key whever it is used, including all match history for that user as the key in the foosbot-match-history table. Alternatively, some method of switching to generated user IDs, linked to the HipChat ID if available. This would still require a rename command for non hipchat users, but wouldn't need to rewrite all match history for that user as the key in the foosbot-match-history table would not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant