Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help to fix CI, review, and get PRs merged #1086

Closed
rafaelweingartner opened this issue Nov 27, 2020 · 9 comments
Closed

Help to fix CI, review, and get PRs merged #1086

rafaelweingartner opened this issue Nov 27, 2020 · 9 comments

Comments

@rafaelweingartner
Copy link
Contributor

Hello @chungg, @jd, @sileht,
We have currently the following PRs open:

We have already been able to get PR #1056 merged.

We see that there are some issues with the CI. How can we help you guys fixing the CI process, and possibly getting some reviews and PRs merged?

We would like to contribute more, but we are a bit lost on how to reach people that can merge the PRs for instance.

@jd
Copy link
Member

jd commented Nov 30, 2020

Thanks for the ping. We can't really spend time fixing the CI, but happy to do some review.
Adding @tobias-urdin who should be on the list of core reviewers if he ever accepts it. You can ping @gnocchixyz/devs to ping everyone at once.

@tobias-urdin
Copy link
Contributor

I will be able to do reviews, I won't be able to work on the CI for some more time though due to internal projects.

@rafaelweingartner
Copy link
Contributor Author

We are actually offering help, not just asking to fix the CI. If you guys allow us to, we would like to contribute more, such as fixing the CI. Currently we have some open PRs, and probably in the future we will have more to contribute back to the community. However, we see that the community needs a health and stable CI and CD process. Therefore, if you guys are comfortable, we would like to help you guys with it.

@jd
Copy link
Member

jd commented Dec 1, 2020

Yes, happy to get help. Most of the team is now working on other things, but if new people wants to come and help, we're happy to onboard new people in the team. We just added @tobias-urdin to the team — they fixed the CI a few weeks ago.
We'll make our best to review your PR in the meantime. 😄

@tobias-urdin
Copy link
Contributor

That would be great! I have some pending PRs that tries to fix some things, seeing as master is red again that's a good place to start. I wanted to get stable/4.3 branch green after I got master green but haven't got to it yet.

@tobias-urdin
Copy link
Contributor

There is now patches pending to fix CI for master, the stable branch still needs to be fixed.

@rafaelweingartner
Copy link
Contributor Author

rafaelweingartner commented Dec 22, 2020

@tobias-urdin the PRs to master were not working on master. We managed to fix that in our PRs. Can you guys reconsider it?

Our PRs are all green now.

@tobias-urdin
Copy link
Contributor

tobias-urdin commented Dec 23, 2020

@gnocchixyz/devs #1062 and #1059

@tobias-urdin
Copy link
Contributor

Closing as I'm following up in #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants