Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types warning #7

Open
natew opened this issue Jun 18, 2017 · 5 comments
Open

prop-types warning #7

natew opened this issue Jun 18, 2017 · 5 comments

Comments

@natew
Copy link
Contributor

natew commented Jun 18, 2017

Get this when using react-tunnel:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

from:

function createProvider(React) {
  var Component = React.Component;
  var PropTypes = React.PropTypes;
@natew
Copy link
Contributor Author

natew commented Aug 23, 2017

Would you release a fix if I submit a PR?

@alanshaw
Copy link

this now errors Cannot read property 'object' of undefined

any chance you can publish a new version with the fix?

@agrcrobles
Copy link

Hey there, I found this library fits is super well with my needs!

I had done some minors tweaks mostly on the tests and published react-tunnel-16 and made it work finely with CRA still need to figure how to make it work with react-native + react 16.

I will send a PR once I have the tests passing.

@gnoff
Copy link
Owner

gnoff commented Dec 1, 2017

@agrcrobles I'll look for the PR

Please note however that this lib is subject to the same limitations of context that say react-router is where a connected component can easily block updates. Have you looked at https://github.com/ReactTraining/react-broadcast instead? it implements a subscription model to avoid this and I would probably use this lib for my own future needs for this reason alone.

If you aren't using shouldComponentUpdate then react-tunnel should still work well but that's a fairly large limitation.

@agrcrobles
Copy link

Thanks for the advice @gnoff!
I will probably end up using react-broadcast as you are suggesting, but since a new version of react-context is comming up most likely all libraries will need an upgrade.

I will send a PR with my current stuffs as of now, as I made it work with CRA and react version 16.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants