Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add an Events field to the transaction #42

Closed
jinoosss opened this issue May 3, 2024 · 3 comments
Closed

[feature] Add an Events field to the transaction #42

jinoosss opened this issue May 3, 2024 · 3 comments

Comments

@jinoosss
Copy link
Member

jinoosss commented May 3, 2024

Description

gnolang/gno#1653 as a change,
adds data to the Events field in the transaction result.

Add functionality to tx-indexer to handle events data.
The tx-indexer should be able to filter and verify the data in events.

@jinoosss
Copy link
Member Author

jinoosss commented May 3, 2024

Hi @zivkovicmilos @ajnavarro ,
I'd love to hear your thoughts on this feature.

Is it enough to just add the Events field to transaction filters and models only?
Or would it be better to add Event related queries as well ?

@ajnavarro
Copy link
Collaborator

Hi @jinoosss . What you did adding Events to transactions looks like the way to go for me.

@jinoosss
Copy link
Member Author

jinoosss commented Jun 5, 2024

Hi @ajnavarro ,
I apologize, I'm late.

I've updated the relevant PR.

If you don't mind, could you please review this PR? #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants