Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Scrollbar is provided by GTK+2 #18

Closed
garrett opened this issue Jun 23, 2011 · 10 comments
Closed

Scrollbar is provided by GTK+2 #18

garrett opened this issue Jun 23, 2011 · 10 comments
Labels

Comments

@garrett
Copy link
Member

garrett commented Jun 23, 2011

Should we look into providing an Adwaita scrollbar in the theme? I think it's possible...

@marb
Copy link
Contributor

marb commented Jun 25, 2011

Scrollbars should be defined in chrome/global/scrollbars.css. After adding chrome/global line in chrome.manifest, Firefox overrides default interface style with values form chrome/global css files. But there is nothing there besides scrollbars, and whole firefox becomes unstyled mess.

@garrett
Copy link
Member Author

garrett commented Jun 25, 2011

Just a thought: Given the simplicity of the scrollbar, it would probably be best to theme it using pure CSS instead of using images. We could use things like border-radius.

However, given the way XUL sometimes works, I'm not 100% sure if this is possible. Sometimes things you think will work do not, and sometimes things may work.

Also, it would be nice if we could somehow make the width of the scrollbar inherit from the standard width of the GTK+ theme... if it could be possible to do so.

@marb
Copy link
Contributor

marb commented Jun 26, 2011

About the scrollbars width - I know. But as I had this narrower images already done, I used them to check if it will work, and as a starting point.

Scrollbars made only with CSS - good idea, but right now I also don't know is it possible.

@garrett
Copy link
Member Author

garrett commented Jun 26, 2011

I can look into it further too... but as for now, I've been using a GTK+2 theme that looks like the GTK+3 one to get the Adwaita look for my scroolbars.

As it's not handled by default, I do think we probably should handle this in the theme.

If GNOME 3.2 does include a better GTK+2 theme (with proper scrollbars), then we can yank support for it in the future (unless it really looks/acts native — which it should, anyway).

@marb
Copy link
Contributor

marb commented Jun 26, 2011

It looks like it can be done with CSS only - I'm working on it.
But yeah, we should use native scrollbars when official GTK+2 theme will be fixed.

I've tried Aldabra theme for GTK+2 but it has issues, and even if it would be perfect, many people don't use it or don't know about it.

@garrett
Copy link
Member Author

garrett commented Jun 27, 2011

I agree on all counts. (:

Let me know if you want me to help you out.

@marb
Copy link
Contributor

marb commented Jun 27, 2011

Scrollbars are ready.

The biggest problem for me right now is git ;] I never used it and I made some mistakes with commits, etc, and I don't know how to resolve it. Should I request to pull everything and You review my commits and merge good ones?

@garrett
Copy link
Member Author

garrett commented Jun 27, 2011

If it's at a working state, I can do a single commit as a squashed merge.

@pulb
Copy link
Member

pulb commented Jun 27, 2011

(I commented on the <a "href=https://github.com/adwaita-firefox-team/adwaita-firefox/pull/25" >pull request itself)

@garrett
Copy link
Member Author

garrett commented Jul 3, 2011

I'm closing this, as we have a correct looking scrollbar now. Thanks! (:

@garrett garrett closed this as completed Jul 3, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants