-
Notifications
You must be signed in to change notification settings - Fork 139
Scrollbar is provided by GTK+2 #18
Comments
Scrollbars should be defined in chrome/global/scrollbars.css. After adding chrome/global line in chrome.manifest, Firefox overrides default interface style with values form chrome/global css files. But there is nothing there besides scrollbars, and whole firefox becomes unstyled mess. |
Just a thought: Given the simplicity of the scrollbar, it would probably be best to theme it using pure CSS instead of using images. We could use things like border-radius. However, given the way XUL sometimes works, I'm not 100% sure if this is possible. Sometimes things you think will work do not, and sometimes things may work. Also, it would be nice if we could somehow make the width of the scrollbar inherit from the standard width of the GTK+ theme... if it could be possible to do so. |
About the scrollbars width - I know. But as I had this narrower images already done, I used them to check if it will work, and as a starting point. Scrollbars made only with CSS - good idea, but right now I also don't know is it possible. |
I can look into it further too... but as for now, I've been using a GTK+2 theme that looks like the GTK+3 one to get the Adwaita look for my scroolbars. As it's not handled by default, I do think we probably should handle this in the theme. If GNOME 3.2 does include a better GTK+2 theme (with proper scrollbars), then we can yank support for it in the future (unless it really looks/acts native — which it should, anyway). |
It looks like it can be done with CSS only - I'm working on it. I've tried Aldabra theme for GTK+2 but it has issues, and even if it would be perfect, many people don't use it or don't know about it. |
I agree on all counts. (: Let me know if you want me to help you out. |
Scrollbars are ready. The biggest problem for me right now is git ;] I never used it and I made some mistakes with commits, etc, and I don't know how to resolve it. Should I request to pull everything and You review my commits and merge good ones? |
If it's at a working state, I can do a single commit as a squashed merge. |
(I commented on the <a "href=https://github.com/adwaita-firefox-team/adwaita-firefox/pull/25" >pull request itself) |
I'm closing this, as we have a correct looking scrollbar now. Thanks! (: |
Should we look into providing an Adwaita scrollbar in the theme? I think it's possible...
The text was updated successfully, but these errors were encountered: